Skip to content

Conversation

@pendo324
Copy link
Contributor

@pendo324 pendo324 commented Jan 7, 2026

Summary

Stops trying to chown/chmod EBS volumes on Windows

Implementation details

Simple exclusion of the function call based on platform

Testing

Description for the changelog

Fixes EBS volumes failing to mount on Windows due to chown/chmod

Additional Information

Does this PR include breaking model changes? If so, Have you added transformation functions?
No

Does this PR include the addition of new environment variables in the README?
No

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pendo324 pendo324 requested a review from a team as a code owner January 7, 2026 23:53
@pendo324 pendo324 requested review from kiryl1 and removed request for a team January 7, 2026 23:53
@pendo324
Copy link
Contributor Author

pendo324 commented Jan 8, 2026

PTAL at the new revision @singholt @kiryl1.

I tried to split the logic between platforms as sanely as possible

@singholt singholt changed the base branch from master to dev January 8, 2026 22:49
@singholt
Copy link
Contributor

singholt commented Jan 8, 2026

PTAL at the new revision @singholt @kiryl1.

I tried to split the logic between platforms as sanely as possible

Thank you. Please update the unit tests too. See failing PR check. Also rebase your base branch against the dev branch in this repo. The failing static check is fixed by #4834

Signed-off-by: Justin Alvarez <alvajus@amazon.com>
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324 pendo324 force-pushed the fix-windows-chmod-chown-error branch from b8c36f5 to d34df8b Compare January 8, 2026 23:31
@singholt singholt enabled auto-merge (squash) January 9, 2026 21:50
@singholt singholt merged commit 13d0cb7 into aws:dev Jan 9, 2026
43 of 44 checks passed
@prateekchaudhry prateekchaudhry mentioned this pull request Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants