Skip to content

Commit f788d88

Browse files
committed
feat(build): Update qchatbuild.py comments to use generic placeholders
- Replace hardcoded 'qchat' in comments with {chat_binary} placeholder - Add REBRANDING_GUIDE.md to .gitignore πŸ€– Assisted by Amazon Q Developer
1 parent 7362da6 commit f788d88

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

β€Ž.gitignoreβ€Ž

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,3 +49,4 @@ book/
4949
.env*
5050

5151
run-build.sh
52+
REBRANDING_GUIDE.md

β€Žbuild-scripts/qchatbuild.pyβ€Ž

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ def cd_build_signed_package(exe_path: pathlib.Path):
201201
```
202202
package
203203
β”œβ”€ EXECUTABLES_TO_SIGN
204-
| β”œβ”€ qchat
204+
| β”œβ”€ {chat_binary}
205205
```
206206
"""
207207
# Trying a different format without manifest.yaml and placing EXECUTABLES_TO_SIGN
@@ -376,7 +376,7 @@ def sign_and_notarize(signing_data: CdSigningData, chat_path: pathlib.Path) -> p
376376

377377
def build_macos(chat_path: pathlib.Path, signing_data: CdSigningData | None):
378378
"""
379-
Creates a qchat.zip under the build directory.
379+
Creates a chat binary zip under the build directory.
380380
"""
381381
chat_dst = BUILD_DIR / CHAT_BINARY_NAME
382382
chat_dst.unlink(missing_ok=True)
@@ -495,7 +495,7 @@ def build_linux(chat_path: pathlib.Path, signer: GpgSigner | None):
495495
Creates tar.gz, tar.xz, tar.zst, and zip archives under `BUILD_DIR`.
496496
497497
Each archive has the following structure:
498-
- archive/qchat
498+
- archive/{chat_binary}
499499
"""
500500
archive_name = CHAT_BINARY_NAME
501501

0 commit comments

Comments
Β (0)