-
Notifications
You must be signed in to change notification settings - Fork 396
feat: /usage #1177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: /usage #1177
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1177 +/- ##
==========================================
+ Coverage 14.03% 14.12% +0.08%
==========================================
Files 2366 2366
Lines 205468 205778 +310
Branches 185832 186142 +310
==========================================
+ Hits 28845 29065 +220
- Misses 175198 175293 +95
+ Partials 1425 1420 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0d06190 to
559245b
Compare
crates/q_cli/src/cli/chat/mod.rs
Outdated
|
|
||
| const RESPONSE_TIMEOUT_CONTENT: &str = "Response timed out - message took too long to generate"; | ||
|
|
||
| const CONTEXT_WINDOW_SIZE: usize = 200_000; // tokens |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have some shared behavior with summarization_state around here too, like have this be the window size and the summarization state MAX_CHARS constant be derived from this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea moved this to summarization_state
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which one is the source of the truth? The 200k tokens or 500k chars?
Rn I'm just dividing the char count by 3 to get tokens. With that logic, the new derived MAX_CHARS would be 600k, not 500k
fb92f16 to
ac5721c
Compare
ac5721c to
d5fb526
Compare
d5fb526 to
d1ce4c0
Compare
Area.mp4
Currently, I'm basically reconstructing the
FigConverationStateoutput and that's gonna be hard to scale and maintain. It's a beta feature with rough est. Will follow up with a more accurate representation once #1175 is resolved.Follow on ticket: #1178