Skip to content

Conversation

@GoodluckH
Copy link
Contributor

@GoodluckH GoodluckH commented Apr 10, 2025

Area.mp4

Currently, I'm basically reconstructing the FigConverationState output and that's gonna be hard to scale and maintain. It's a beta feature with rough est. Will follow up with a more accurate representation once #1175 is resolved.

Follow on ticket: #1178

@GoodluckH GoodluckH requested a review from a team April 10, 2025 18:57
@GoodluckH GoodluckH linked an issue Apr 10, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2025

Codecov Report

Attention: Patch coverage is 12.08791% with 80 lines in your changes missing coverage. Please review.

Project coverage is 14.12%. Comparing base (c633c9d) to head (d1ce4c0).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
crates/q_cli/src/cli/chat/mod.rs 10.84% 74 Missing ⚠️
crates/q_cli/src/cli/chat/conversation_state.rs 0.00% 3 Missing ⚠️
crates/q_cli/src/util/token_counter.rs 50.00% 2 Missing ⚠️
crates/q_cli/src/cli/chat/command.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1177      +/-   ##
==========================================
+ Coverage   14.03%   14.12%   +0.08%     
==========================================
  Files        2366     2366              
  Lines      205468   205778     +310     
  Branches   185832   186142     +310     
==========================================
+ Hits        28845    29065     +220     
- Misses     175198   175293      +95     
+ Partials     1425     1420       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GoodluckH GoodluckH force-pushed the 1154-usage-feature branch from 0d06190 to 559245b Compare April 10, 2025 22:28
@GoodluckH GoodluckH self-assigned this Apr 11, 2025

const RESPONSE_TIMEOUT_CONTENT: &str = "Response timed out - message took too long to generate";

const CONTEXT_WINDOW_SIZE: usize = 200_000; // tokens
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have some shared behavior with summarization_state around here too, like have this be the window size and the summarization state MAX_CHARS constant be derived from this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea moved this to summarization_state

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which one is the source of the truth? The 200k tokens or 500k chars?

Rn I'm just dividing the char count by 3 to get tokens. With that logic, the new derived MAX_CHARS would be 600k, not 500k

@GoodluckH GoodluckH force-pushed the 1154-usage-feature branch 2 times, most recently from fb92f16 to ac5721c Compare April 14, 2025 20:31
@GoodluckH GoodluckH requested a review from brandonskiser April 15, 2025 01:22
@GoodluckH GoodluckH force-pushed the 1154-usage-feature branch from ac5721c to d5fb526 Compare April 16, 2025 00:01
@GoodluckH GoodluckH force-pushed the 1154-usage-feature branch from d5fb526 to d1ce4c0 Compare April 16, 2025 00:02
@GoodluckH GoodluckH merged commit 194fd10 into main Apr 16, 2025
20 checks passed
@GoodluckH GoodluckH deleted the 1154-usage-feature branch April 16, 2025 00:23
This was referenced Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

/usage feature

3 participants