feat: QCHAT_PROCESS_ID and pre-push hook. #1368
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_PROCESS_ID" This is designed to allow tools to check if they are running inside the context of a Q Chat child process, such as an MCP server, Q Chat calling a shell command, or in git hooks. Included a sample of what a pre-push-hook may look like that uses this.
…at sessions This hook checks for the QCHAT_PROCESS_ID environment variable and blocks push operations when an Amazon Q chat session is active, preventing accidental pushes during interactive sessions. 🤖 Assisted by [Amazon Q Developer](https://aws.amazon.com/q/developer)
Remove the deprecated husky initialization lines from .husky/pre-push to prevent failures with husky v10.0.0. 🤖 Assisted by [Amazon Q Developer](https://aws.amazon.com/q/developer)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1368 +/- ##
==========================================
- Coverage 14.29% 14.29% -0.01%
==========================================
Files 2335 2335
Lines 201913 201933 +20
Branches 182277 182297 +20
==========================================
+ Hits 28862 28863 +1
- Misses 171646 171664 +18
- Partials 1405 1406 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Hey! Sorry for the late response - can you rebase main and push again? |
Contributor
|
Closed, implemented in #1793 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Q Chat now sets an environment variable with its process id, which may be used by downstream processes (MCP Servers, Shell Commands, Git hooks), to specify behaviour based on being run inside Q Chat.
A sample git pre-push hook is included in docs/samples/ to show how it could work, and the husky hooks in the project have been updated to include the push prevention.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.