Skip to content

Conversation

@grant0417
Copy link
Contributor

@grant0417 grant0417 commented Dec 2, 2024

This PR changes the name of the packages to use the @aws namespace which is needed to publish them on npm.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@grant0417 grant0417 requested a review from a team December 2, 2024 17:34
@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 42.22222% with 26 lines in your changes missing coverage. Please review.

Project coverage is 12.28%. Comparing base (4d757c4) to head (0f228d8).

Files with missing lines Patch % Lines
packages/autocomplete/src/App.tsx 0.00% 5 Missing ⚠️
packages/api-bindings/codegen/generate-requests.ts 0.00% 2 Missing ⚠️
packages/autocomplete/src/components/Preview.tsx 0.00% 2 Missing ⚠️
...ackages/autocomplete/src/components/Suggestion.tsx 0.00% 2 Missing ⚠️
packages/autocomplete/src/main.tsx 0.00% 2 Missing ⚠️
packages/autocomplete/src/tests/window.ts 0.00% 2 Missing ⚠️
packages/dashboard/src/App.tsx 0.00% 2 Missing ⚠️
packages/autocomplete/src/actions.ts 0.00% 1 Missing ⚠️
...ges/autocomplete/src/components/SuggestionIcon.tsx 0.00% 1 Missing ⚠️
.../src/components/notifications/AuthNotification.tsx 0.00% 1 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
- Coverage   12.28%   12.28%   -0.01%     
==========================================
  Files        2246     2246              
  Lines      191012   191014       +2     
  Branches   174929   174929              
==========================================
  Hits        23468    23468              
- Misses     166377   166379       +2     
  Partials     1167     1167              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grant0417 grant0417 force-pushed the rename-npm-namespace branch from 4041bd1 to 0544c1e Compare December 2, 2024 17:44
@grant0417 grant0417 changed the title build: rename npm packages to @amazon-q-developer-cli namespace build: rename npm packages to @aws Dec 2, 2024
@grant0417 grant0417 changed the title build: rename npm packages to @aws build: rename npm packages to @aws namespace Dec 2, 2024
@grant0417 grant0417 force-pushed the rename-npm-namespace branch from 0544c1e to f8790af Compare December 4, 2024 18:33
@grant0417 grant0417 force-pushed the rename-npm-namespace branch from 323231c to 2465695 Compare December 11, 2024 20:08
@grant0417 grant0417 force-pushed the rename-npm-namespace branch from 94574fa to d027e9f Compare December 11, 2024 20:15
@@ -1,5 +1,5 @@
{
"name": "@amzn/fig-io-api-bindings-wrappers",
"name": "@aws/amazon-q-developer-cli-api-bindings-wrappers",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would seriously prefer q-cli-api-bindings-wrappers instead of amazon-q-developer-cli-api-bindings-wrappers. Same with the other packages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this keeps the same prefix as the github repo name, it keeps it consistent but long

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then we change the name of the repo

@grant0417 grant0417 merged commit fccd8e0 into aws:main Dec 12, 2024
10 checks passed
jlhood pushed a commit to jlhood/amazon-q-developer-cli that referenced this pull request Mar 16, 2025
* abc

* fix packages

* fix pnpm lock

* fmt fix
hayemaxi pushed a commit to hayemaxi/amazon-q-developer-cli that referenced this pull request Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants