-
Notifications
You must be signed in to change notification settings - Fork 396
build: rename npm packages to @aws namespace #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #166 +/- ##
==========================================
- Coverage 12.28% 12.28% -0.01%
==========================================
Files 2246 2246
Lines 191012 191014 +2
Branches 174929 174929
==========================================
Hits 23468 23468
- Misses 166377 166379 +2
Partials 1167 1167 ☔ View full report in Codecov by Sentry. |
4041bd1 to
0544c1e
Compare
0544c1e to
f8790af
Compare
323231c to
2465695
Compare
94574fa to
d027e9f
Compare
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "name": "@amzn/fig-io-api-bindings-wrappers", | |||
| "name": "@aws/amazon-q-developer-cli-api-bindings-wrappers", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would seriously prefer q-cli-api-bindings-wrappers instead of amazon-q-developer-cli-api-bindings-wrappers. Same with the other packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this keeps the same prefix as the github repo name, it keeps it consistent but long
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then we change the name of the repo
* abc * fix packages * fix pnpm lock * fmt fix
This PR changes the name of the packages to use the
@awsnamespace which is needed to publish them on npm.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.