Skip to content

Fix: Make shell command purpose display more natural #1815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chaynabors merged 2 commits into from
May 14, 2025
Merged

Fix: Make shell command purpose display more natural #1815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ef6322
ui
evanliu048 May 13, 2025
5c78db0
ui
evanliu048 May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/chat-cli/src/cli/chat/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,7 @@ const TRUST_ALL_TEXT: &str = color_print::cstr! {"<green!>All tools are now trus

const TOOL_BULLET: &str = " ● ";
const CONTINUATION_LINE: &str = " ⋮ ";
const PURPOSE_ARROW: &str = " ↳ ";

pub async fn launch_chat(database: &mut Database, telemetry: &TelemetryThread, args: cli::Chat) -> Result<ExitCode> {
let trust_tools = args.trust_tools.map(|mut tools| {
Expand Down
10 changes: 8 additions & 2 deletions crates/chat-cli/src/cli/chat/tools/execute_bash.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,11 @@ use super::{
MAX_TOOL_RESPONSE_SIZE,
OutputKind,
};
use crate::cli::chat::{
CONTINUATION_LINE,
PURPOSE_ARROW,
};
use crate::platform::Context;

const READONLY_COMMANDS: &[&str] = &["ls", "cat", "echo", "pwd", "which", "head", "tail", "find", "grep"];

#[derive(Debug, Clone, Deserialize)]
Expand Down Expand Up @@ -127,8 +130,11 @@ impl ExecuteBash {
if let Some(summary) = &self.summary {
queue!(
updates,
style::Print(CONTINUATION_LINE),
style::Print("\n"),
style::Print(PURPOSE_ARROW),
style::SetForegroundColor(Color::Blue),
style::Print("\nPurpose: "),
style::Print("Purpose: "),
style::ResetColor,
style::Print(summary),
style::Print("\n"),
Expand Down
Loading