Skip to content

Persistant conv invariant #1829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chaynabors merged 7 commits into from
May 14, 2025
Merged

Persistant conv invariant #1829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
aab54df
verifies conversation invariants on conversation deserialization
dingfeli May 13, 2025
8aa696d
adds logic to check tool use history invariants
dingfeli May 14, 2025
5f195de
modifies history invariant function to take parameter to explicitly c…
dingfeli May 14, 2025
0f5a0cd
Merge branch 'main' into persistant-conv-invariant
dingfeli May 14, 2025
63219e6
force updates conversation state on restart
dingfeli May 14, 2025
0e8bd55
Merge branch 'main' into persistant-conv-invariant
dingfeli May 14, 2025
c0dbb0c
removes extra update
dingfeli May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/chat-cli/src/cli/chat/conversation_state.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,8 +514,8 @@ impl ConversationState {
.expect("unable to construct conversation state")
}

pub async fn update_state(&mut self) {
let needs_update = self.tool_manager.has_new_stuff.load(Ordering::Acquire);
pub async fn update_state(&mut self, force_update: bool) {
let needs_update = self.tool_manager.has_new_stuff.load(Ordering::Acquire) || force_update;
if !needs_update {
return;
}
Expand Down
4 changes: 2 additions & 2 deletions crates/chat-cli/src/cli/chat/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,7 +572,7 @@ impl ChatContext {
cs.reload_serialized_state(Arc::clone(&ctx), Some(output.clone())).await;
input = Some(input.unwrap_or("In a few words, summarize our conversation so far.".to_owned()));
cs.tool_manager = tool_manager;
cs.enforce_tool_use_history_invariants(false);
cs.update_state(true).await;
cs
} else {
ConversationState::new(
Expand Down Expand Up @@ -816,7 +816,7 @@ impl ChatContext {
debug!(?chat_state, "changing to state");

// Update conversation state with new tool information
self.conversation_state.update_state().await;
self.conversation_state.update_state(false).await;

let result = match chat_state {
ChatState::PromptUser {
Expand Down
Loading