fix: Sanitize hidden Unicode characters from user and tool inputs#2435
Merged
evanliu048 merged 7 commits intomainfrom Aug 4, 2025
Merged
fix: Sanitize hidden Unicode characters from user and tool inputs#2435evanliu048 merged 7 commits intomainfrom
evanliu048 merged 7 commits intomainfrom
Conversation
Contributor
|
LGTM but why is the windows CI failing? |
Contributor
Oh I see windows was never supported by Skim. Weird how this failure comes up now and not in any of the PRs before this. edit: nvm I see that there is a change in the related file. |
dingfeli
approved these changes
Aug 4, 2025
chaynabors
requested changes
Aug 4, 2025
Member
chaynabors
left a comment
There was a problem hiding this comment.
Don't merge until I chat with appsec
chaynabors
approved these changes
Aug 4, 2025
Contributor
Author
re import the func in chat/mod.rs and all the CI passed now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR addresses a potential prompt injection issue by removing hidden/control Unicode characters from:
User input (e.g. chat prompt)
Tool outputs (e.g.
fs_read,execute_bashresponses)Specifically, we strip characters in the following ranges:
These characters are rarely used in normal text but may be exploited to hide invisible instructions.
Unit tests are added to verify both detection and removal behavior.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.