feat: disable text styling in --no-interactive mode #2464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StoneDot
changed the title
StoneDot
force-pushed
the
remove-styling-when-interactive
branch
from
bdbf2e1 to
1ec2b4c
Compare
StoneDot
changed the title
Automatically partially disable ANSI color codes and styling when running in non-interactive mode.
- Add a session-scoped enable_styling flag to ChatSession
- Create conditional styling macros (execute_conditional!, queue_conditional!)
- Implement an IsStyling trait for crossterm styling commands
- Remove the response prefix ("> ") in non-interactive mode
- Add a raw text output path that bypasses the markdown parser when styling is disabled
- Text styling is automatically disabled when the --no-interactive flag is used
StoneDot
force-pushed
the
remove-styling-when-interactive
branch
from
1ec2b4c to
5c91b63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically partially disable ANSI color codes and styling when running in non-interactive mode.
Issue #, if available:
#993
Description of changes:
Automatically disables text styling in
--no-interactivemode to ensure clean output for programmatic usage and script integration.Testing examples:
Before (non-interactive had ANSI codes):
After (clean output):
Discussion notes:
I already noticed that other codes should also be changed to suppress styling. If complete stderr styling removal is needed, it can be addressed in follow-up PRs or added to this one based on feedback. However, I believe this PR can be a good starting point for these changes.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.