interactive creation for allowed commands with execute_bash #2487
+380
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omansour
changed the title
…eate allowed command patterns. Patterns are immediately saved to disk if you use an agent. in /tools, display the allowed commands
omansour
force-pushed
the
trusted-commands-extension2
branch
from
4744658 to
826db79
Compare
omansour
changed the title
- Update interactive 'a' option to generate regex patterns instead of glob patterns - Fix pattern generation for option 1: use regex::escape() for exact commands - Fix pattern generation for option 2: use 'command\s.*' to match 'command ' + anything (but not command alone) - Remove glob-based pattern matching code that conflicted with main branch's regex approach - Update unit tests to reflect regex pattern behavior - Fix bug where commands like 'git log -1' weren't matching the allowed pattern Key changes: - Option 1 now generates: 'touch\ test\.txt' (escaped exact match) - Option 2 now generates: 'git\s.*' (matches 'git ' + anything, not 'git' alone) - Maintains compatibility with main branch's regex-based allowedCommands system - All tests passing with proper regex pattern validation Fixes issue where interactive menu generated incompatible glob patterns instead of the expected regex patterns used by the main branch.
omansour
force-pushed
the
trusted-commands-extension2
branch
from
9eecb1e to
6e17850
Compare
- Format crates/chat-cli/src/cli/chat/mod.rs - Format crates/chat-cli/src/cli/chat/tools/execute/mod.rs This ensures the code follows the project's formatting standards and should make the GitHub Action 'Fmt' check pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
related to
#1260 [RFC] Extra-granular Tool Permissions
#2483 Regex-formatted allowed commands for execute_bash tool
why ?
See the video for a short demo.
Screen.Recording.2025-08-05.at.11.19.11_2.mov
I will be more than happy to discuss about this feature and adapt the functionalities if needed.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.