-
Notifications
You must be signed in to change notification settings - Fork 396
feat: Path based loading for agent #2859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Implementation aside, I think this is a change that involves product level decisions. The way this feature is designed is fairly opinionated and is one that is based on a new concept / notion of a namespace in the agent directory, which is itself something that warrants some discussions. On that front, I'll bring this up with the team and I'll update it in the reply to this comment accordingly. |
f8d9528 to
86e6289
Compare
|
@dingfeli I addressed all of your feedback, let me know what you think |
86e6289 to
8004f69
Compare
|
So I spoke with the team some more and the consensus is that this implementation is slightly premature and it would make more sense for when / if we have repositories for agents. I do think this is something we would want to eventually support but perhaps to compliment a better thought out agent distribution paradigm. |
|
Revisiting this as per Matt's request. Left some more comments. |
8004f69 to
bced7b1
Compare
bced7b1 to
e5f42eb
Compare
People can now do `q chat --agent team/myagent` in addition to the current `q chat --agent myagent`. This will enable people to better organize their agents in Q CLI directory
e5f42eb to
a04074f
Compare
People can now do
q chat --agent team/myagentin addition to the currentq chat --agent myagent. This will enable better management of agents in Q CLI directoryBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.