Skip to content

Conversation

@brandonskiser
Copy link
Contributor

@brandonskiser brandonskiser commented Mar 3, 2025

Description of changes:

  • macOS build is failing since going to 1.85, reverting to unblock builds.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@brandonskiser brandonskiser marked this pull request as ready for review March 3, 2025 21:01
@brandonskiser brandonskiser requested a review from a team March 3, 2025 21:01
@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.36%. Comparing base (4cd8367) to head (dccff2f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #712   +/-   ##
=======================================
  Coverage   13.36%   13.36%           
=======================================
  Files        2360     2360           
  Lines      202698   202698           
  Branches   183240   183240           
=======================================
  Hits        27095    27095           
  Misses     174199   174199           
  Partials     1404     1404           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brandonskiser brandonskiser merged commit 540cfdb into main Mar 3, 2025
20 checks passed
@brandonskiser brandonskiser deleted the bskiser/rust-version branch March 3, 2025 21:02
brandonskiser added a commit that referenced this pull request Mar 4, 2025
* fix: use rust 1.85 (#710)

* fix: use rust 1.85

* fix: typos failing on typ

* fix: codepipeline failures when running cargo (#711)

* fix: revert back to rust 1.84 (#712)

* fix: infinite loop when formatting paths

* remove tracing init from test
chaynabors pushed a commit that referenced this pull request Mar 4, 2025
* fix: use rust 1.85 (#710)

* fix: use rust 1.85

* fix: typos failing on typ

* fix: codepipeline failures when running cargo (#711)

* fix: revert back to rust 1.84 (#712)

* fix: infinite loop when formatting paths

* remove tracing init from test
chaynabors pushed a commit that referenced this pull request Mar 4, 2025
* fix: infinite loop when formatting paths (#713)

* fix: use rust 1.85 (#710)

* fix: use rust 1.85

* fix: typos failing on typ

* fix: codepipeline failures when running cargo (#711)

* fix: revert back to rust 1.84 (#712)

* fix: infinite loop when formatting paths

* remove tracing init from test

* fix: correct history truncation, tool interruption on ctrl c

* fix: lints
chaynabors pushed a commit that referenced this pull request Mar 4, 2025
* fix: use rust 1.85 (#710)

* fix: use rust 1.85

* fix: typos failing on typ

* fix: codepipeline failures when running cargo (#711)

* fix: revert back to rust 1.84 (#712)

* feat: updates welcome msg

* fix: fmt

* fix: edits list to reflect current capabilities

* fix: updates msg based on new changes

---------

Co-authored-by: Brandon Kiser <[email protected]>
jlhood pushed a commit to jlhood/amazon-q-developer-cli that referenced this pull request Mar 16, 2025
* fix: infinite loop when formatting paths (aws#713)

* fix: use rust 1.85 (aws#710)

* fix: use rust 1.85

* fix: typos failing on typ

* fix: codepipeline failures when running cargo (aws#711)

* fix: revert back to rust 1.84 (aws#712)

* fix: infinite loop when formatting paths

* remove tracing init from test

* fix: correct history truncation, tool interruption on ctrl c

* fix: lints
jlhood pushed a commit to jlhood/amazon-q-developer-cli that referenced this pull request Mar 16, 2025
* fix: use rust 1.85 (aws#710)

* fix: use rust 1.85

* fix: typos failing on typ

* fix: codepipeline failures when running cargo (aws#711)

* fix: revert back to rust 1.84 (aws#712)

* feat: updates welcome msg

* fix: fmt

* fix: edits list to reflect current capabilities

* fix: updates msg based on new changes

---------

Co-authored-by: Brandon Kiser <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants