Skip to content

Sync branches #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aws-sdk-dotnet-automation merged 2 commits into from
Dec 16, 2025
Merged

Sync branches #140

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cdf62b4
Make tests compatible with .NET Framework 3.5
normj Dec 16, 2025
da3bca3
Merge pull request #139 from aws/normj/fix-tests
aws-sdk-dotnet-automation Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions test/UnitTests/S3ecImplementedCryptographicOperationsTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,15 @@ public class S3ecImplementedCryptographicOperationsTest
public static void EqualReturnsTrue(int byteLength)
{
byte[] testArray = new byte[byteLength];
#if BCL35
var rng = RandomNumberGenerator.Create();
rng.GetBytes(testArray);
#else
using (var rng = RandomNumberGenerator.Create())
{
rng.GetBytes(testArray);
}
#endif

byte[] testArray2 = new byte[byteLength];
Array.Copy(testArray, testArray2, byteLength);
Expand All @@ -45,10 +50,15 @@ public static void EqualReturnsTrue(int byteLength)
public static void UnequalReturnsFalse(int byteLength)
{
byte[] testArray = new byte[byteLength];
#if BCL35
var rng = RandomNumberGenerator.Create();
rng.GetBytes(testArray);
#else
using (var rng = RandomNumberGenerator.Create())
{
rng.GetBytes(testArray);
}
#endif

byte[] testArray2 = new byte[byteLength];
Array.Copy(testArray, testArray2, byteLength);
Expand All @@ -72,10 +82,15 @@ public static void UnequalReturnsFalse(int byteLength)
public static void DifferentLengthsReturnFalse(int byteLength)
{
byte[] testArray = new byte[byteLength];
#if BCL35
var rng = RandomNumberGenerator.Create();
rng.GetBytes(testArray);
#else
using (var rng = RandomNumberGenerator.Create())
{
rng.GetBytes(testArray);
}
#endif

byte[] testArray2 = new byte[byteLength];
Array.Copy(testArray, testArray2, byteLength);
Expand All @@ -93,6 +108,7 @@ public static void DifferentLengthsReturnFalse(int byteLength)
Assert.False(isEqualB, "value missing last byte, value");
}

#if BCL35
[Fact]
public static void HasCorrectMethodImpl()
{
Expand All @@ -106,5 +122,6 @@ public static void HasCorrectMethodImpl()
MethodImplAttributes.NoInlining | MethodImplAttributes.NoOptimization,
mi.MethodImplementationFlags);
}
#endif
}
}
Loading