Allow user to skip or select datatypes with aperf #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two new options are provided for the user to configure the data collected with aperf. * collect_only - select only the datatypes to collect. * skip_only - select only the datatypes to *not* collect. Update the integration tests to run in its own process with rusty-fork. This allows each intergration to run as a stand alone, as is expected.
geoffreyblake
requested changes
May 14, 2025
Comment on lines
+301
to
+304
| SystemInfo, | ||
| CpuUtilization, | ||
| KernelConfig, | ||
| Sysctl, |
There was a problem hiding this comment.
I'm not sure there is really mandatory data, if we're going to allow users to skip collecting, we might as well let them collect nothing.
| @@ -107,6 +107,10 @@ To see a step-by-step example, please see our example [here](./EXAMPLE.md) | |||
|
|
|||
| `--profile-java` profile JVMs by PID or name using async-profiler (default profiles all JVMs) | |||
|
|
|||
| `--collect-only` collect only these data types | |||
There was a problem hiding this comment.
We should only have an opt out option in my opinion.
| Netstat, | ||
| PerfProfile, | ||
| Flamegraph, | ||
| JavaProfile, |
There was a problem hiding this comment.
are not PerfProfile, Flamegraph, JavaProfile managed by --profile and --java-profile switches?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two new options are provided for the user to configure the data collected with aperf.
Update the integration tests to run in its own process with rusty-fork. This allows each intergration to run as a stand alone, as is expected.
Added a report which compares 2 runs. 1 run was run and only collected interrupts. The other run skipped only the vmstat and interrupts.
skip_collect.tar.gz
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.