Conversation
rix0rrr
left a comment
There was a problem hiding this comment.
Thanks! I think I can approve this, but it needs a bump of the bootstrap template version as well.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #112 +/- ##
==========================================
+ Coverage 84.46% 84.73% +0.26%
==========================================
Files 205 205
Lines 35648 35648
Branches 4579 4597 +18
==========================================
+ Hits 30109 30205 +96
+ Misses 5393 5291 -102
- Partials 146 152 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Head branch was pushed to by a user without write access
|
Thanks for the feedback, @rix0rrr -- I've incremented the template version. |
|
@graydenshand You can stop updating from main now. We take care of it from here. Updating will just invalidate the tests and make everything take longer. |
This PR modifies the default bootstrap template to support EMR Serverless containers.
Without this policy, containers created using the
DockerImageAssetconstruct cannot be used with EMR Serverless applications.There is precedence for this pattern to support Lambda function containers, so I don't think this should be too controversial of a change.
Relevant documentation on using custom images in EMR Serverless:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license