Skip to content

feat(bootstrap): Add ECR resource policy for emr-serverless containers#112

Merged
mrgrain merged 7 commits intoaws:mainfrom
graydenshand:feat/emr-serverless-containers
Mar 3, 2025
Merged

feat(bootstrap): Add ECR resource policy for emr-serverless containers#112
mrgrain merged 7 commits intoaws:mainfrom
graydenshand:feat/emr-serverless-containers

Conversation

@graydenshand
Copy link
Contributor

@graydenshand graydenshand commented Feb 24, 2025

This PR modifies the default bootstrap template to support EMR Serverless containers.

Without this policy, containers created using the DockerImageAsset construct cannot be used with EMR Serverless applications.

There is precedence for this pattern to support Lambda function containers, so I don't think this should be too controversial of a change.

Relevant documentation on using custom images in EMR Serverless:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@graydenshand graydenshand changed the title Bootstrap template | Add ECR resource policy for emr-serverless containers feat (bootstrap): Add ECR resource policy for emr-serverless containers Feb 24, 2025
@graydenshand graydenshand changed the title feat (bootstrap): Add ECR resource policy for emr-serverless containers feat(bootstrap): Add ECR resource policy for emr-serverless containers Feb 24, 2025
@graydenshand
Copy link
Contributor Author

@mrgrain @kaizencc @rix0rrr Anyone able to take a look at this?

Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think I can approve this, but it needs a bump of the bootstrap template version as well.

@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.73%. Comparing base (806d851) to head (b271ebf).
Report is 367 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #112      +/-   ##
==========================================
+ Coverage   84.46%   84.73%   +0.26%     
==========================================
  Files         205      205              
  Lines       35648    35648              
  Branches     4579     4597      +18     
==========================================
+ Hits        30109    30205      +96     
+ Misses       5393     5291     -102     
- Partials      146      152       +6     
Flag Coverage Δ
suite.unit 84.73% <ø> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

auto-merge was automatically disabled March 3, 2025 13:01

Head branch was pushed to by a user without write access

@graydenshand
Copy link
Contributor Author

Thanks for the feedback, @rix0rrr -- I've incremented the template version.

@mrgrain
Copy link
Contributor

mrgrain commented Mar 3, 2025

@graydenshand You can stop updating from main now. We take care of it from here. Updating will just invalidate the tests and make everything take longer.

@mrgrain mrgrain enabled auto-merge March 3, 2025 14:47
@mrgrain mrgrain added this pull request to the merge queue Mar 3, 2025
Merged via the queue into aws:main with commit 478113d Mar 3, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments