chore(toolkit-lib): publish toolkit-lib docs to s3 (in dryrun)#114
Merged
chore(toolkit-lib): publish toolkit-lib docs to s3 (in dryrun)#114
Conversation
mrgrain
commented
Feb 24, 2025
Comment on lines
+110
to
+111
| `&& aws s3 cp --dryrun dist/${this.props.artifactPath} $S3_URI \\`, | ||
| '&& aws s3 cp --dryrun $LATEST s3://$BUCKET_NAME/$LATEST) \\', |
Contributor
Author
There was a problem hiding this comment.
--dryrun for now to check everything is working
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
==========================================
- Coverage 84.80% 84.75% -0.06%
==========================================
Files 196 196
Lines 35089 35089
Branches 4557 4546 -11
==========================================
- Hits 29758 29739 -19
- Misses 5183 5205 +22
+ Partials 148 145 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kaizencc
approved these changes
Feb 24, 2025
mrgrain
force-pushed
the
mrgrain/s3-publish
branch
from
ab0a539 to
e1597f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a release for the toolkit-lib s3 docs to be published to s3.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license