chore(toolkit-lib): publish-local script is not working#115
Merged
Conversation
kaizencc
reviewed
Feb 24, 2025
| npm pkg set version=$reset | ||
| npm pkg set dependencies.@aws-cdk/cloudformation-diff=^$reset | ||
| npm pkg set dependencies.@aws-cdk/cloudformation-diff=^$reset`` | ||
| npm pkg set dependencies.@aws-cdk/cloud-assembly-schema=^$reset`` |
Contributor
There was a problem hiding this comment.
are these "`" intentional? never seen before but im not good at shell scripting
Contributor
Author
There was a problem hiding this comment.
no. thanks for catching!
mrgrain
commented
Feb 24, 2025
kaizencc
approved these changes
Feb 24, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #115 +/- ##
==========================================
- Coverage 84.70% 84.47% -0.23%
==========================================
Files 196 196
Lines 35089 35089
Branches 4533 4521 -12
==========================================
- Hits 29722 29643 -79
- Misses 5227 5306 +79
Partials 140 140
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license