Skip to content

chore(adc-publishing): build standalone release in 'release' workflow#119

Merged
mrgrain merged 4 commits intomainfrom
huijbers/build-standalone-at-release
Feb 24, 2025
Merged

chore(adc-publishing): build standalone release in 'release' workflow#119
mrgrain merged 4 commits intomainfrom
huijbers/build-standalone-at-release

Conversation

@rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Feb 24, 2025

release doesn't call build, but has its own implementation of building instead.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

`release` doesn't call `build`, but has its own implementation of
building.
@rix0rrr rix0rrr requested a review from a team February 24, 2025 20:30
@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.67%. Comparing base (672ce46) to head (8a452da).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
+ Coverage   84.41%   84.67%   +0.25%     
==========================================
  Files         196      196              
  Lines       35089    35089              
  Branches     4521     4538      +17     
==========================================
+ Hits        29622    29711      +89     
+ Misses       5325     5231      -94     
- Partials      142      147       +5     
Flag Coverage Δ
suite.unit 84.67% <ø> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrgrain mrgrain added the pr/exempt-integ-test Skips the integ test steps if set. label Feb 24, 2025
@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Feb 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 24, 2025
@mrgrain mrgrain added this pull request to the merge queue Feb 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 24, 2025
@mrgrain mrgrain added this pull request to the merge queue Feb 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 24, 2025
@mrgrain mrgrain enabled auto-merge February 24, 2025 22:07
Signed-off-by: github-actions <github-actions@github.com>
@mrgrain mrgrain added this pull request to the merge queue Feb 24, 2025
Merged via the queue into main with commit a23376e Feb 24, 2025
11 checks passed
@mrgrain mrgrain deleted the huijbers/build-standalone-at-release branch February 24, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr/exempt-integ-test Skips the integ test steps if set.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants