Skip to content

fix(cdk-assets): use same SDK versions as other packages#121

Merged
aws-cdk-automation merged 3 commits intomainfrom
mrgrain/fix/cdk-assets/sdk-versions
Feb 24, 2025
Merged

fix(cdk-assets): use same SDK versions as other packages#121
aws-cdk-automation merged 3 commits intomainfrom
mrgrain/fix/cdk-assets/sdk-versions

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Feb 24, 2025

Fixes dependency resolution warnings when installing toolkit-lib.

npm warn ERESOLVE overriding peer dependency
npm warn While resolving: @aws-sdk/lib-storage@3.750.0
npm warn Found: @aws-sdk/client-s3@3.741.0
npm warn node_modules/@aws-sdk/client-s3
npm warn   @aws-sdk/client-s3@"3.741" from @aws-cdk/toolkit-lib@0.1.0
npm warn   node_modules/@aws-cdk/toolkit-lib
npm warn     @aws-cdk/toolkit-lib@"*" from the root project
npm warn   2 more (@aws-sdk/lib-storage, cdk-assets)
npm warn
npm warn Could not resolve dependency:
npm warn peer @aws-sdk/client-s3@"^3.750.0" from @aws-sdk/lib-storage@3.750.0
npm warn node_modules/cdk-assets/node_modules/@aws-sdk/lib-storage
npm warn   @aws-sdk/lib-storage@"^3.750.0" from cdk-assets@3.0.0-rc.144
npm warn   node_modules/cdk-assets
npm warn
npm warn Conflicting peer dependency: @aws-sdk/client-s3@3.750.0
npm warn node_modules/@aws-sdk/client-s3
npm warn   peer @aws-sdk/client-s3@"^3.750.0" from @aws-sdk/lib-storage@3.750.0
npm warn   node_modules/cdk-assets/node_modules/@aws-sdk/lib-storage
npm warn     @aws-sdk/lib-storage@"^3.750.0" from cdk-assets@3.0.0-rc.144
npm warn     node_modules/cdk-assets

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.43%. Comparing base (3e228d6) to head (13a533c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
- Coverage   84.80%   84.43%   -0.38%     
==========================================
  Files         196      196              
  Lines       35089    35089              
  Branches     4557     4524      -33     
==========================================
- Hits        29758    29628     -130     
- Misses       5183     5319     +136     
+ Partials      148      142       -6     
Flag Coverage Δ
suite.unit 84.43% <ø> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: github-actions <github-actions@github.com>
@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Feb 24, 2025
Merged via the queue into main with commit 298a6c1 Feb 24, 2025
20 checks passed
@aws-cdk-automation aws-cdk-automation deleted the mrgrain/fix/cdk-assets/sdk-versions branch February 24, 2025 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants