feat(cli): can match notices against Node version#128
Merged
aws-cdk-automation merged 4 commits intomainfrom Feb 25, 2025
Merged
feat(cli): can match notices against Node version#128aws-cdk-automation merged 4 commits intomainfrom
aws-cdk-automation merged 4 commits intomainfrom
Conversation
rix0rrr
commented
Feb 25, 2025
| } | ||
|
|
||
| export class NoticesFilter { | ||
| export abstract class NoticesFilter { |
Contributor
Author
There was a problem hiding this comment.
To make it very clear that this class doesn't have any instance methods on purpose.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #128 +/- ##
==========================================
- Coverage 84.74% 84.59% -0.16%
==========================================
Files 196 196
Lines 35089 35187 +98
Branches 4546 4537 -9
==========================================
+ Hits 29736 29765 +29
- Misses 5207 5271 +64
- Partials 146 151 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
otaviomacedo
approved these changes
Feb 25, 2025
github-merge-queue bot
pushed a commit
to cdklabs/aws-cdk-notices
that referenced
this pull request
Mar 3, 2025
Relies on Node matching support for notices: aws/aws-cdk-cli#128 --------- Signed-off-by: github-actions <github-actions@github.com> Co-authored-by: github-actions <github-actions@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows publishing notices that match against the version of Node we're executing on.
Implemented by generalizing the code that matches against CLI version and bootstrap versions: it can now match against arbitrary named components.
Also implement more complex matching rules: currently we match the pattern if one of them matches:
Instead, generalize to Disjunctive Normal Form and treat the current case as a special case of DNF where every conjunction has one element:
This way we can write rules to say that "component X on Node version Y" should get a notice.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license