chore: correct require approval default #152
Conversation
kaizencc
had a problem deploying
to
integ-approval
GitHub Actions
Failure
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #152 +/- ##
==========================================
+ Coverage 84.61% 84.71% +0.09%
==========================================
Files 198 204 +6
Lines 35400 35647 +247
Branches 4557 4595 +38
==========================================
+ Hits 29954 30197 +243
+ Misses 5304 5291 -13
- Partials 142 159 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: github-actions <[email protected]>
aws-cdk-automation
had a problem deploying
to
integ-approval
GitHub Actions
Failure
| "schemaHash": "1063bafc562a50e6dafeb8664275f5d61ff631542d47992963bfaf5cf277ab6e", | ||
| "revision": 40 | ||
| "schemaHash": "4244f1ed6fcece9abcfb319c637fd2eb863a5deef9cc36f05f7d52377ce60012", | ||
| "revision": 41 |
There was a problem hiding this comment.
Hmm. Is there a way to avoid this...? @rix0rrr ?
There was a problem hiding this comment.
+1 seems unnecessary for a doc change
There was a problem hiding this comment.
this is from the self mutation so what can i do here :(
There was a problem hiding this comment.
💩 Maybe we can wait and group it with the text change? We could push directly to main, but I'm not sure about the consequences :(
There was a problem hiding this comment.
You can hax0r around it by copying the new hash but moving the old version number back.
There was a problem hiding this comment.
Like this?
| "revision": 41 | |
| "revision": 40 |
There was a problem hiding this comment.
i guess that should work?
Co-authored-by: Momo Kornher <[email protected]>
Co-authored-by: Momo Kornher <[email protected]>
Signed-off-by: github-actions <[email protected]>
6 participants
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license