Skip to content

Conversation

@rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Feb 28, 2025

Add a new field to the asset schema: displayName.

If supplied, it will be used instead of the asset ID for display purposes in cdk-assets and in the CLI.

This adds support for display names to the contract and to the CLI. A future PR in aws-cdk-lib will make it possible to configure display names on Asset objects, and add the same support to CDK Pipelines.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Add a new field to the asset schema: `displayName`.

If supplied, it will be used instead of the asset ID for display
purposes in `cdk-assets` and in the CLI.

This adds support for display names to the contract and to the CLI.  A
future PR in `aws-cdk-lib` will make it possible to configure display
names on Asset objects, and add the same support to CDK Pipelines.
@rix0rrr rix0rrr requested a review from a team February 28, 2025 13:54
@aws-cdk-automation aws-cdk-automation requested a review from a team February 28, 2025 13:55
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 77.14286% with 16 lines in your changes missing coverage. Please review.

Project coverage is 85.19%. Comparing base (12299ff) to head (5d36bad).
Report is 31 commits behind head on main.

Files with missing lines Patch % Lines
packages/cdk-assets/lib/asset-manifest.ts 81.81% 8 Missing ⚠️
packages/cdk-assets/lib/publishing.ts 0.00% 6 Missing ⚠️
...ackages/aws-cdk/lib/api/deployments/deployments.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
+ Coverage   84.84%   85.19%   +0.35%     
==========================================
  Files         205      205              
  Lines       35648    35701      +53     
  Branches     4617     4633      +16     
==========================================
+ Hits        30245    30417     +172     
+ Misses       5245     5128     -117     
+ Partials      158      156       -2     
Flag Coverage Δ
suite.unit 85.19% <77.14%> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rix0rrr rix0rrr temporarily deployed to integ-approval March 3, 2025 13:26 — with GitHub Actions Inactive
Signed-off-by: github-actions <[email protected]>
@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Mar 3, 2025
Merged via the queue into main with commit 7c65899 Mar 3, 2025
20 checks passed
@aws-cdk-automation aws-cdk-automation deleted the huijbers/display-name-assets branch March 3, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants