Skip to content

Conversation

@tttol
Copy link
Contributor

@tttol tttol commented Mar 3, 2025

Fixes #

In CONTRIBUTING.md, the command for running integration tests does not work:

$ bin/run-suite -s ../../../../aws-cdk-cli cli-integ-tests -f 2.179.0-t 'cli-lib deploy'
Error: Cannot use --framework-version with --use-source
    at main (/Users/t-takahashi/Documents/workspace/aws-cdk-cli-testing/packages/@aws-cdk-testing/cli-integ/lib/cli/run-suite.js:85:19)

The -f option cannot be used with -s, so I removed -f from the snippet.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team March 3, 2025 04:33
@mrgrain mrgrain added the pr/exempt-integ-test Skips the integ test steps if set. label Mar 3, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.73%. Comparing base (48244a9) to head (6b7319a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #180      +/-   ##
==========================================
- Coverage   84.75%   84.73%   -0.03%     
==========================================
  Files         205      205              
  Lines       35648    35648              
  Branches     4604     4606       +2     
==========================================
- Hits        30215    30207       -8     
+ Misses       5286     5285       -1     
- Partials      147      156       +9     
Flag Coverage Δ
suite.unit 84.73% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Mar 3, 2025
Merged via the queue into aws:main with commit a294dbd Mar 3, 2025
11 checks passed
@tttol tttol deleted the remove-option branch April 27, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr/exempt-integ-test Skips the integ test steps if set.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants