Skip to content

Conversation

@rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Mar 3, 2025

Otherwise we can't find the AWS SDK dependencies that we need.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Otherwise we can't find the AWS SDK dependencies that we need.
@rix0rrr rix0rrr requested a review from a team March 3, 2025 10:23
@aws-cdk-automation aws-cdk-automation requested a review from a team March 3, 2025 10:24
@mrgrain mrgrain added the pr/exempt-integ-test Skips the integ test steps if set. label Mar 3, 2025
@rix0rrr rix0rrr closed this Mar 3, 2025
auto-merge was automatically disabled March 3, 2025 10:26

Pull request was closed

@rix0rrr rix0rrr reopened this Mar 3, 2025
- name: Fetch tags from origin repo
run: |-
git remote add upstream https://github.com/aws/aws-cdk-cli.git
git remote add upstream git@github.com:aws/aws-cdk-cli.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self-mutation will catch this but ;(

@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.78%. Comparing base (09ef5a0) to head (c456a64).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
+ Coverage   84.64%   84.78%   +0.13%     
==========================================
  Files         205      205              
  Lines       35648    35648              
  Branches     4591     4597       +6     
==========================================
+ Hits        30175    30223      +48     
+ Misses       5321     5275      -46     
+ Partials      152      150       -2     
Flag Coverage Δ
suite.unit 84.78% <ø> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: github-actions <[email protected]>
@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Mar 3, 2025
Merged via the queue into main with commit 753f7f6 Mar 3, 2025
11 checks passed
@aws-cdk-automation aws-cdk-automation deleted the huijbers/install-deps branch March 3, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr/exempt-integ-test Skips the integ test steps if set.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants