fix: don't show built-in Node lifetime warnings #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have moved to using Notices to display Node support warnings, so we should disable the built-in warnings provided by `@jsii/check-node`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #186 +/- ##
==========================================
+ Coverage 84.84% 85.10% +0.26%
==========================================
Files 205 207 +2
Lines 35648 35723 +75
Branches 4617 4622 +5
==========================================
+ Hits 30245 30403 +158
+ Misses 5245 5167 -78
+ Partials 158 153 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: github-actions <[email protected]>
mrgrain
approved these changes
Mar 4, 2025
Signed-off-by: github-actions <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have moved to using Notices to display Node support warnings, so we should disable the built-in warnings provided by
@jsii/check-node.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license