Skip to content

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Mar 4, 2025

Fixes '@aws-cdk/toolkit-lib' has no exported member named 'ToolkitError'

Because we are now moving parts of the public API into a shared package, we also need to export the respective types.
During the regular build, type declarations are not bundled. So we need to take care of it afterwards.
This is not ideal, but required. Thankfully the temporary package is a, well, temporary construct and we are actively working to get rid of it (first by adding new stuff, then by moving everything to toolkit-lib).


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mrgrain mrgrain added the pr/exempt-integ-test Skips the integ test steps if set. label Mar 4, 2025
@github-actions github-actions bot added the p2 label Mar 4, 2025
@mrgrain mrgrain closed this Mar 4, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team March 4, 2025 10:23
@mrgrain mrgrain reopened this Mar 4, 2025
@mrgrain mrgrain changed the title fix(toolkit-lib): ToolkitError type is not exported fix(toolkit-lib): ToolkitError is not exported Mar 4, 2025
@mrgrain mrgrain force-pushed the mrgrain/fix/toolkit-error-type-not-exported branch from 6f6f7e4 to dc15ead Compare March 4, 2025 10:47
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.03%. Comparing base (3710b78) to head (dc15ead).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #187      +/-   ##
==========================================
- Coverage   85.25%   85.03%   -0.23%     
==========================================
  Files         207      207              
  Lines       35723    35723              
  Branches     4644     4635       -9     
==========================================
- Hits        30457    30377      -80     
- Misses       5114     5185      +71     
- Partials      152      161       +9     
Flag Coverage Δ
suite.unit 85.03% <ø> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Mar 4, 2025
Merged via the queue into main with commit 04cdb98 Mar 4, 2025
11 checks passed
@aws-cdk-automation aws-cdk-automation deleted the mrgrain/fix/toolkit-error-type-not-exported branch March 4, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2 pr/exempt-integ-test Skips the integ test steps if set.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants