Skip to content

Conversation

@rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Mar 4, 2025

We are currently running cdk-assets v3 as latest, and it is working fine. Make this the official disttag for this version.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

We are currently running `cdk-assets` v3 as `latest`, and it is working
fine. Make this the official disttag for this version.
@rix0rrr rix0rrr added the pr/exempt-integ-test Skips the integ test steps if set. label Mar 4, 2025
@github-actions github-actions bot added the p2 label Mar 4, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team March 4, 2025 10:38
@mrgrain mrgrain disabled auto-merge March 4, 2025 10:45
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.07%. Comparing base (3710b78) to head (957df53).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #189      +/-   ##
==========================================
- Coverage   85.25%   85.07%   -0.19%     
==========================================
  Files         207      207              
  Lines       35723    35723              
  Branches     4644     4621      -23     
==========================================
- Hits        30457    30391      -66     
- Misses       5114     5181      +67     
+ Partials      152      151       -1     
Flag Coverage Δ
suite.unit 85.07% <ø> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rix0rrr
Copy link
Contributor Author

rix0rrr commented Mar 4, 2025

Waiting a bit with the merge

We're not merging this just yet, let's wait a couple more days.

@rix0rrr rix0rrr added this pull request to the merge queue Mar 5, 2025
Merged via the queue into main with commit c46717c Mar 5, 2025
18 checks passed
@rix0rrr rix0rrr deleted the huijbers/assets-latest branch March 5, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2 pr/exempt-integ-test Skips the integ test steps if set.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants