chore: use the same typescript version everywhere #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rix0rrr
approved these changes
Mar 4, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #190 +/- ##
==========================================
+ Coverage 84.89% 84.97% +0.08%
==========================================
Files 207 207
Lines 35723 35723
Branches 4611 4607 -4
==========================================
+ Hits 30326 30355 +29
+ Misses 5248 5217 -31
- Partials 149 151 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mrgrain
force-pushed
the
mrgrain/chore/same-ts-version-everywhere
branch
from
8b4c2bd to
f573d30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting warnings from eslint plugins about an unsupported typescript version (5.8). Then I noticed that the monorepo root is the only package that doesn't use the "global" version.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license