fix: handle cross-device link error in build-standalone-zip task #195
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When building the AWS CDK CLI, a .zip file is created in a temporary directory and moved afterward.
In certain environments, "cross-device link" fails. When the user's workspace is in a mounted volume, moving of a file fails during the build step because
fs.rename()only works when the source and destination are in the same filesystem.Solution
Copy the source file to the destination and delete the source file. This achieves the same result, but prevents us from running into limitations across filesystems.
Testing
Ran
yarn buildsuccessfully and all tests pass.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license