Skip to content

Conversation

@kaizencc
Copy link
Contributor

@kaizencc kaizencc commented Mar 5, 2025

Looks like this on the doc site:

Screenshot 2025-03-05 at 5 03 51 PM

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@kaizencc kaizencc added the pr/exempt-integ-test Skips the integ test steps if set. label Mar 5, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team March 5, 2025 22:06
@github-actions github-actions bot added the p2 label Mar 5, 2025
@kaizencc
Copy link
Contributor Author

kaizencc commented Mar 5, 2025

I have no reason besides I think this is the right place to put the code registry. imo it doesn't make sense to have it on the base level so under the Toolkitumbrella seems like the most logical place to put it.

@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.97%. Comparing base (035c527) to head (f8bf813).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #199      +/-   ##
==========================================
- Coverage   85.28%   84.97%   -0.31%     
==========================================
  Files         207      207              
  Lines       35706    35706              
  Branches     4633     4604      -29     
==========================================
- Hits        30451    30342     -109     
- Misses       5102     5213     +111     
+ Partials      153      151       -2     
Flag Coverage Δ
suite.unit 84.97% <ø> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: github-actions <[email protected]>
@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Mar 5, 2025
Merged via the queue into main with commit e145d55 Mar 5, 2025
11 checks passed
@aws-cdk-automation aws-cdk-automation deleted the conroy/coderegistry branch March 5, 2025 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2 pr/exempt-integ-test Skips the integ test steps if set.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants