refactor(cli): make the cli use more shared code #207
Conversation
| '@typescript-eslint/consistent-type-imports': 'error', | ||
| }); | ||
|
|
||
| tmpToolkitHelpers.gitignore.addPatterns('test/**/*.map'); |
There was a problem hiding this comment.
No idea how this file got there in the first place. But it won't anymore in future.
| export abstract class BasePublishProgressListener implements IPublishProgressListener { | ||
| protected readonly ioHost: IIoHost; | ||
| protected readonly action: ToolkitAction; | ||
| protected readonly action: IoMessaging['action']; |
There was a problem hiding this comment.
Plan is to not have the action here but to have an ActionAwareIoHost. See importer.ts as an example. Eventually we will just be passing ActionAwareIoHost hosts around.
| private readonly cfn: Deployments; | ||
| private readonly ioHost: IIoHost; | ||
| private readonly action: ToolkitAction; | ||
| private readonly ioHost: ActionAwareIoHost; |
| this.cfn = props.deployments; | ||
| this.ioHost = props.ioHost; | ||
| this.action = props.action; | ||
| this.ioHost = withAction(props.ioHost, props.action as any); |
There was a problem hiding this comment.
Almost the future. Eventually this class should just get an ActionAwareIoHost in the first place.
| } | ||
|
|
||
| debug('CDK toolkit version:', version.displayVersion()); | ||
| debug('CDK Toolkit CLI version:', version.displayVersion()); |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #207 +/- ##
==========================================
- Coverage 85.27% 85.12% -0.16%
==========================================
Files 207 208 +1
Lines 35837 35775 -62
Branches 4656 4645 -11
==========================================
- Hits 30559 30452 -107
- Misses 5120 5171 +51
+ Partials 158 152 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mrgrain
force-pushed
the
mrgrain/refactor/cli-uses-shared-code
branch
from
9c39e7f to
7ef9d82
Compare
mrgrain
force-pushed
the
mrgrain/refactor/cli-uses-shared-code
branch
from
4bbfb9d to
979c0d5
Compare
|
Added |
4 participants
Removes duplicated interfaces.
I know this is messy. Please bear with me 🙈
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license