-
Notifications
You must be signed in to change notification settings - Fork 69
refactor(cli): use IoHelper in internal APIs #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c3ff921 to
b49dfc4
Compare
| caBundlePath: argv['ca-bundle-path'], | ||
| }, | ||
| logger: new SdkToCliLogger(ioHost), | ||
| logger: new SdkToCliLogger(asIoHelper(ioHost, ioHost.currentAction as any)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ioHost.currentAction is extending ToolkitAction with additional values. This is fine.
Same again in L189
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #209 +/- ##
==========================================
+ Coverage 85.04% 85.26% +0.22%
==========================================
Files 208 208
Lines 35786 35710 -76
Branches 4633 4652 +19
==========================================
+ Hits 30435 30449 +14
+ Misses 5200 5111 -89
+ Partials 151 150 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| } as CreateChangeSetCommandInput); | ||
| }); | ||
|
|
||
| describe('ci=true', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deleted since this test was just testing that the CI dependent stream selection works.
172f0dd to
c6d756a
Compare
kaizencc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like a big refactor, but there are no additional things you're sliding in and if the tests pass, i trust you...
|
Added |
This PR is a lot. There is no good way of reviewing it, so thanks for taking the time.
The main change here is the usage of the
IoHelperin all internal APIs. Previously we would pass anIoHostand anactionaround as pair, but separate value. Instead we now use theIoHelperwhich knows how to send messages with an action.I also decided to rename all properties and params respectively. This is partly what makes the PR so large. Note that all changes are to private APIs.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license