Skip to content

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Mar 8, 2025

Main change here is to fail the build when the docs generation has warnings. This enforces that all referenced message data interfaces are exported and documented.

Made some organizational changes and how the message registry is presented.
Also added basic support for links to external interface from cxapi.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mrgrain mrgrain added the pr/exempt-integ-test Skips the integ test steps if set. label Mar 8, 2025
@github-actions github-actions bot added the p2 label Mar 8, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team March 8, 2025 15:23
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.13%. Comparing base (c71caf0) to head (3cfe69e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #210      +/-   ##
==========================================
- Coverage   85.18%   85.13%   -0.06%     
==========================================
  Files         208      208              
  Lines       35710    35710              
  Branches     4665     4639      -26     
==========================================
- Hits        30421    30402      -19     
- Misses       5132     5157      +25     
+ Partials      157      151       -6     
Flag Coverage Δ
suite.unit 85.13% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Mar 9, 2025
Merged via the queue into main with commit ac56f9b Mar 9, 2025
18 checks passed
@aws-cdk-automation aws-cdk-automation deleted the mrgrain/fix/ensure-all-payload-is-exported branch March 9, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2 pr/exempt-integ-test Skips the integ test steps if set.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants