refactor(cli): replace getters and setters with a public field #215
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
CliIoHosthad a number of fields that had the following pattern:There is no additional code in the getters and setters other than directly forwarding every access to a private field, so the above is equivalent to the following:
Since the above is simpler, this PR proposed to remove the getters and setters and just expose the field mutably.
If we ever want to run additional code in a setter in some of these fields, we can refactor back to a getter and setter pair without impacting source or binary compatibility (forwards compatibility was the argument in the olden C++ and Java days for pre-emptively wrapping fields in getters and setters, but doesn't apply in JS land).
(🤖 This PR was generated using AI)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license