Skip to content

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Mar 10, 2025

  • glob and uuid ship with types in their latest versions (which we use)
  • make-runnable is an unused dev dependency
  • json-diff and source-map-support are unused prod dependencies
  • We don't need the CLI_SDK_VERSION switch anymore, everything is on v3

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mrgrain mrgrain temporarily deployed to integ-approval March 10, 2025 09:38 — with GitHub Actions Inactive
@aws-cdk-automation aws-cdk-automation requested a review from a team March 10, 2025 09:39
@github-actions github-actions bot added the p2 label Mar 10, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.09%. Comparing base (4566d8d) to head (b8a77d2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #216      +/-   ##
==========================================
+ Coverage   85.02%   85.09%   +0.07%     
==========================================
  Files         208      208              
  Lines       35657    35657              
  Branches     4630     4634       +4     
==========================================
+ Hits        30318    30343      +25     
+ Misses       5181     5159      -22     
+ Partials      158      155       -3     
Flag Coverage Δ
suite.unit 85.09% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mrgrain
Copy link
Contributor Author

mrgrain commented Mar 10, 2025

exempted integ tests because the failure is due to an unstable test

@mrgrain mrgrain closed this Mar 10, 2025
auto-merge was automatically disabled March 10, 2025 14:25

Pull request was closed

@mrgrain mrgrain reopened this Mar 10, 2025
@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Mar 10, 2025
Merged via the queue into main with commit db60595 Mar 10, 2025
33 of 35 checks passed
@aws-cdk-automation aws-cdk-automation deleted the mrgrain/chore/remove-unused-deps branch March 10, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2 pr/exempt-integ-test Skips the integ test steps if set.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants