chore: in tests, publish both upstream and candidate versions of schema #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need 2 different versions of `@aws-cdk/cloud-assembly-schema` versions available at the same time: - The candidate version is used by `cdk-assets` (which doesn't bundle it) - The released version is used by `aws-cdk-lib` (which is used as part of tests. Requires updating to a new version of cdklabs-projen-project-types.
rix0rrr
had a problem deploying
to
integ-approval
GitHub Actions
Failure
auto-merge was automatically disabled
March 11, 2025 11:06
Pull request was closed
iliapolo
approved these changes
Mar 11, 2025
mrgrain
approved these changes
Mar 11, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #222 +/- ##
==========================================
+ Coverage 84.84% 85.21% +0.36%
==========================================
Files 208 208
Lines 35564 35564
Branches 4612 4651 +39
==========================================
+ Hits 30175 30305 +130
+ Misses 5239 5109 -130
Partials 150 150
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need 2 different versions of
@aws-cdk/cloud-assembly-schemaversions available at the same time:cdk-assets(which doesn't bundle it)aws-cdk-lib(which is used as part of tests.Requires updating to a new version of cdklabs-projen-project-types.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license