Skip to content

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Mar 13, 2025

This just annoyed me a lot. Let's fix it!
No other changes than moving tests around.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mrgrain mrgrain added the pr/exempt-integ-test Skips the integ test steps if set. label Mar 13, 2025
@github-actions github-actions bot added the p2 label Mar 13, 2025
@mrgrain mrgrain closed this Mar 13, 2025
@mrgrain mrgrain reopened this Mar 13, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team March 13, 2025 18:42
Copy link
Contributor

@iankhou iankhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (and Claude 3.5)

@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.24%. Comparing base (f0ad96e) to head (a33862c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #228      +/-   ##
==========================================
+ Coverage   84.86%   85.24%   +0.38%     
==========================================
  Files         208      208              
  Lines       35600    35600              
  Branches     4622     4650      +28     
==========================================
+ Hits        30211    30348     +137     
+ Misses       5235     5104     -131     
+ Partials      154      148       -6     
Flag Coverage Δ
suite.unit 85.24% <ø> (+0.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Mar 13, 2025
Merged via the queue into main with commit 59d44ee Mar 13, 2025
29 of 31 checks passed
@aws-cdk-automation aws-cdk-automation deleted the mrgrain/chore/group-toolkit-tests-correctly branch March 13, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2 pr/exempt-integ-test Skips the integ test steps if set.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants