chore(toolkit-lib): fix s3 docs upload #232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #232 +/- ##
==========================================
+ Coverage 84.88% 84.94% +0.06%
==========================================
Files 208 208
Lines 35680 35680
Branches 4616 4626 +10
==========================================
+ Hits 30287 30309 +22
+ Misses 5247 5223 -24
- Partials 146 148 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| 'echo "$S3_PATH" > "$LATEST"', | ||
| elif echo "$OUTPUT" | grep -q "PreconditionFailed"; then | ||
| # Check specifically for PreconditionFailed in the error output | ||
| echo "::warning::File already exists in S3. Skipping upload." |
Contributor
There was a problem hiding this comment.
Is this the only reason for PreconditionFailed? Is it possible to be even more specific?
Contributor
Author
There was a problem hiding this comment.
To my understanding this is the only possible precondition because the precondition is only created by the --if-none-match option. So that's what we want.
kaizencc
approved these changes
Mar 14, 2025
otaviomacedo
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-write the script to upload the
toolkit-libdocs S3. This has been AI assisted and actually been tested in a testing repo.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license