fix(cli): fix for code scanning alerts: Prototype-polluting assignment #233
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for https://github.com/aws/aws-cdk-cli/security/code-scanning/5 https://github.com/aws/aws-cdk-cli/security/code-scanning/6 https://github.com/aws/aws-cdk-cli/security/code-scanning/7
To fix the prototype pollution vulnerability, we need to ensure that the keys used in the
deepSetfunction do not include any properties that can modifyObject.prototype. This can be achieved by validating the keys in thepatharray and rejecting any keys that are__proto__,constructor, orprototype.The best way to fix this problem without changing existing functionality is to add a validation step before using the keys in the
patharray. We will add a check to ensure that none of the keys in thepatharray are__proto__,constructor, orprototype.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license