-
Notifications
You must be signed in to change notification settings - Fork 69
fix(toolkit-lib): deployment total time includes stray output #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #238 +/- ##
==========================================
+ Coverage 85.09% 85.38% +0.28%
==========================================
Files 206 212 +6
Lines 35215 36068 +853
Branches 4535 4565 +30
==========================================
+ Hits 29966 30795 +829
- Misses 5099 5126 +27
+ Partials 150 147 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kaizencc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small comment
packages/@aws-cdk/tmp-toolkit-helpers/src/api/io/private/span.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meta question for my benefit: what did you ask AI for, and how many iterations did it take for it to get it right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To write the tests. Took about 4 iterations and some manual fixing in between.
Fixes an extra
Deployment <number>at the end of the "Total Time" message reporting the total deployment time.Adds missing test cases for the
MessageSpanfeature (GenAI supported).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license