Skip to content

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Mar 17, 2025

Fixes an extra Deployment <number> at the end of the "Total Time" message reporting the total deployment time.

Adds missing test cases for the MessageSpan feature (GenAI supported).


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team March 17, 2025 10:08
@github-actions github-actions bot added the p2 label Mar 17, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2025

Codecov Report

Attention: Patch coverage is 93.54839% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.38%. Comparing base (cb8a7e0) to head (835338a).

Files with missing lines Patch % Lines
...cdk/tmp-toolkit-helpers/src/api/io/private/span.ts 93.54% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #238      +/-   ##
==========================================
+ Coverage   85.09%   85.38%   +0.28%     
==========================================
  Files         206      212       +6     
  Lines       35215    36068     +853     
  Branches     4535     4565      +30     
==========================================
+ Hits        29966    30795     +829     
- Misses       5099     5126      +27     
+ Partials      150      147       -3     
Flag Coverage Δ
suite.unit 85.38% <93.54%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mrgrain mrgrain marked this pull request as ready for review March 17, 2025 18:21
@mrgrain mrgrain added the pr/exempt-integ-test Skips the integ test steps if set. label Mar 17, 2025
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comment

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meta question for my benefit: what did you ask AI for, and how many iterations did it take for it to get it right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To write the tests. Took about 4 iterations and some manual fixing in between.

@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Mar 18, 2025
Merged via the queue into main with commit ec93ebd Mar 18, 2025
11 checks passed
@aws-cdk-automation aws-cdk-automation deleted the mrgrain/fix/span-extra-output branch March 18, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2 pr/exempt-integ-test Skips the integ test steps if set.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants