refactor(toolkit): resource metadata #243
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #243 +/- ##
==========================================
+ Coverage 85.09% 85.61% +0.51%
==========================================
Files 206 206
Lines 35215 35202 -13
Branches 4535 4584 +49
==========================================
+ Hits 29966 30137 +171
+ Misses 5099 4918 -181
+ Partials 150 147 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kaizencc
left a comment
kaizencc
left a comment
There was a problem hiding this comment.
feel free to merge once comments are responded to :)
| }), | ||
|
|
||
| // 9: Bootstrap | ||
| // 9: Bootstrap (9xxx) |
There was a problem hiding this comment.
i assume by the way you are "enforcing" this that these are not meant to be strongly enforced at all, and will rely on our attention to detail to ensure we follow.
i feel like we are getting to the point where these rules may be hard to get right when we eventually introduce new message codes.
| } | ||
|
|
||
| private findMetadataFor(logicalId: string | undefined): ResourceMetadata | undefined { | ||
| private findMetadataFor(logicalId: string | undefined) { |
There was a problem hiding this comment.
why delete this? seems like we are still returning the same type
|
bypassing integ tests due to unrelated failure |
4 participants
Pulls out resource-metadata extraction into a separate API so it can easily be reused in other places.
Also adds support for resource metadata to
EvaluateCloudFormationTemplate(internal API) in preparation for a change in hotswap.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license