Skip to content

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Mar 19, 2025

This is in preparation of making the value available in a structured message to the IoHost.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mrgrain mrgrain temporarily deployed to integ-approval March 19, 2025 11:10 — with GitHub Actions Inactive
@aws-cdk-automation aws-cdk-automation requested a review from a team March 19, 2025 11:10
@github-actions github-actions bot added the p2 label Mar 19, 2025
@mrgrain mrgrain changed the title chore: adds a structured reason to non hotswappable resources chore: adds well-defined reason to non hotswappable resources Mar 19, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 85.07%. Comparing base (db4029c) to head (ff953f2).

Files with missing lines Patch % Lines
...aws-cdk/lib/api/deployments/hotswap-deployments.ts 73.68% 5 Missing ⚠️
packages/aws-cdk/lib/api/hotswap/common.ts 90.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #252      +/-   ##
==========================================
- Coverage   85.11%   85.07%   -0.05%     
==========================================
  Files         218      218              
  Lines       36517    36548      +31     
  Branches     4584     4570      -14     
==========================================
+ Hits        31082    31093      +11     
- Misses       5289     5310      +21     
+ Partials      146      145       -1     
Flag Coverage Δ
suite.unit 85.07% <87.50%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mrgrain mrgrain force-pushed the mrgrain/feat/non-hotswappable-reason branch from b267a8e to ff953f2 Compare March 19, 2025 11:34
@mrgrain mrgrain added the pr/exempt-integ-test Skips the integ test steps if set. label Mar 19, 2025
@mrgrain mrgrain closed this Mar 19, 2025
auto-merge was automatically disabled March 19, 2025 12:35

Pull request was closed

@mrgrain mrgrain reopened this Mar 19, 2025
@mrgrain
Copy link
Contributor Author

mrgrain commented Mar 19, 2025

applied exemption label because a previous run passed

@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Mar 19, 2025
Merged via the queue into main with commit 4408fb9 Mar 19, 2025
23 of 24 checks passed
@aws-cdk-automation aws-cdk-automation deleted the mrgrain/feat/non-hotswappable-reason branch March 19, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2 pr/exempt-integ-test Skips the integ test steps if set.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants