Skip to content

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Mar 19, 2025

Fixes #


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team March 19, 2025 12:17
@github-actions github-actions bot added the p2 label Mar 19, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 76.41921% with 54 lines in your changes missing coverage. Please review.

Project coverage is 85.21%. Comparing base (4408fb9) to head (a83bd89).

Files with missing lines Patch % Lines
...aws-cdk/lib/api/deployments/hotswap-deployments.ts 75.83% 29 Missing ⚠️
...s/@aws-cdk/tmp-toolkit-helpers/src/util/objects.ts 34.37% 21 Missing ⚠️
...mp-toolkit-helpers/src/util/string-manipulation.ts 57.14% 3 Missing ⚠️
packages/aws-cdk/lib/api/hotswap/common.ts 97.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #253      +/-   ##
==========================================
- Coverage   85.28%   85.21%   -0.07%     
==========================================
  Files         218      218              
  Lines       36548    36551       +3     
  Branches     4600     4595       -5     
==========================================
- Hits        31170    31147      -23     
- Misses       5232     5261      +29     
+ Partials      146      143       -3     
Flag Coverage Δ
suite.unit 85.21% <76.41%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mrgrain mrgrain force-pushed the mrgrain/feat/non-hotswappable-reasources branch from 1d18054 to fd88d41 Compare March 19, 2025 12:43
@mrgrain mrgrain force-pushed the mrgrain/feat/non-hotswappable-reasources branch from fd88d41 to fc5ad5f Compare March 19, 2025 13:18
@mrgrain mrgrain changed the title refactor(cli): various code re-organization in hotswap code stuff Mar 19, 2025
@mrgrain mrgrain marked this pull request as draft March 19, 2025 13:19
auto-merge was automatically disabled March 19, 2025 13:19

Pull request was converted to draft

@mrgrain mrgrain force-pushed the mrgrain/feat/non-hotswappable-reasources branch from fc5ad5f to a83bd89 Compare March 19, 2025 13:40
@mrgrain mrgrain closed this Mar 19, 2025
@mrgrain mrgrain deleted the mrgrain/feat/non-hotswappable-reasources branch March 19, 2025 13:41
@mrgrain mrgrain temporarily deployed to integ-approval March 19, 2025 13:42 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants