Skip to content

Conversation

@kaizencc
Copy link
Contributor

In subsequent examples we type cx as ICloudAssemblySource, so it makes more sense for our examples to show cx as an ICloudAssemblySource and not Promise<ICloudAssemblySource>.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Mar 19, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team March 19, 2025 15:27
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.05%. Comparing base (4408fb9) to head (906a407).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #258      +/-   ##
==========================================
- Coverage   85.28%   85.05%   -0.23%     
==========================================
  Files         218      218              
  Lines       36548    36548              
  Branches     4600     4564      -36     
==========================================
- Hits        31170    31087      -83     
- Misses       5232     5317      +85     
+ Partials      146      144       -2     
Flag Coverage Δ
suite.unit 85.05% <ø> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kaizencc kaizencc added the pr/exempt-integ-test Skips the integ test steps if set. label Mar 19, 2025
@kaizencc kaizencc closed this Mar 19, 2025
auto-merge was automatically disabled March 19, 2025 16:26

Pull request was closed

@kaizencc kaizencc reopened this Mar 19, 2025
@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Mar 19, 2025
Merged via the queue into main with commit a0de04e Mar 19, 2025
26 of 28 checks passed
@aws-cdk-automation aws-cdk-automation deleted the conroy/docs11 branch March 19, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2 pr/exempt-integ-test Skips the integ test steps if set.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants