Skip to content

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Mar 24, 2025

Updates the tree.ts APIs to use an injectable trace function, so that it can easily be used from old and new code paths. At some point in the future this should just take an IoHelper, but not now.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team March 24, 2025 10:49
@github-actions github-actions bot added the p2 label Mar 24, 2025
@mrgrain mrgrain temporarily deployed to integ-approval March 24, 2025 11:04 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.20%. Comparing base (a477c66) to head (c94d0c5).

Files with missing lines Patch % Lines
packages/aws-cdk/lib/api/cxapp/exec.ts 66.66% 1 Missing ⚠️
packages/aws-cdk/lib/api/tree.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #276      +/-   ##
==========================================
- Coverage   85.50%   85.20%   -0.30%     
==========================================
  Files         221      221              
  Lines       36606    36610       +4     
  Branches     4476     4455      -21     
==========================================
- Hits        31300    31195     -105     
- Misses       5209     5320     +111     
+ Partials       97       95       -2     
Flag Coverage Δ
suite.unit 85.20% <85.71%> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: github-actions <[email protected]>
@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Mar 24, 2025
Merged via the queue into main with commit 2dc5a56 Mar 24, 2025
21 checks passed
@aws-cdk-automation aws-cdk-automation deleted the mrgrain/refactor/tree-api branch March 24, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants