Skip to content

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Mar 24, 2025

Introduces a dedicated messaging interface for Context Providers. This is a reduced interface to allow Context Providers send debug messages and in rare cases info messages.

Use of ioHelper in the provideContextValues function is currently still optional until the CloudExecutable supports it as well.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team March 24, 2025 19:16
@github-actions github-actions bot added the p2 label Mar 24, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2025

Codecov Report

Attention: Patch coverage is 91.07143% with 10 lines in your changes missing coverage. Please review.

Project coverage is 85.09%. Comparing base (2dc5a56) to head (ac85e9a).

Files with missing lines Patch % Lines
packages/aws-cdk/lib/context-providers/index.ts 85.96% 8 Missing ⚠️
packages/aws-cdk/lib/api/cxapp/cloud-executable.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #277      +/-   ##
==========================================
- Coverage   85.18%   85.09%   -0.09%     
==========================================
  Files         221      221              
  Lines       36610    36675      +65     
  Branches     4440     4432       -8     
==========================================
+ Hits        31186    31210      +24     
- Misses       5325     5369      +44     
+ Partials       99       96       -3     
Flag Coverage Δ
suite.unit 85.09% <91.07%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: github-actions <[email protected]>
@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Mar 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 25, 2025
@mrgrain mrgrain added this pull request to the merge queue Mar 25, 2025
Merged via the queue into main with commit 289490b Mar 25, 2025
20 checks passed
@mrgrain mrgrain deleted the mrgrain/refactor/context-provider-messaging branch March 25, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants