Skip to content

Conversation

@iankhou
Copy link
Contributor

@iankhou iankhou commented Mar 31, 2025

Allows us to invoke api-extractor to get an outputted JSON file produced from source code and TSDocs.

Ref: https://api-extractor.com/pages/setup/invoking/#4-running-the-tool


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@iankhou iankhou self-assigned this Mar 31, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team March 31, 2025 13:37
@github-actions github-actions bot added the p2 label Mar 31, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.44%. Comparing base (cd35a1c) to head (054f6b2).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #300      +/-   ##
==========================================
+ Coverage   85.24%   85.44%   +0.19%     
==========================================
  Files         222      222              
  Lines       36898    36926      +28     
  Branches     4438     4462      +24     
==========================================
+ Hits        31455    31552      +97     
+ Misses       5348     5277      -71     
- Partials       95       97       +2     
Flag Coverage Δ
suite.unit 85.44% <100.00%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@iankhou iankhou changed the title feat (docs): add api-extractor config feat(docs): add api-extractor config Mar 31, 2025
@iankhou iankhou added the pr/exempt-integ-test Skips the integ test steps if set. label Mar 31, 2025
Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How/where are you planning to run API Extractor? I'd expect the script and the config to live side-by-side (unless there's a very good reason not to).

Also, if it must live here: I think I'd prefer all of our JSON files that are actually config to go through projen. So create a new projen.JsonFile in .projenrc.ts and put the config there I think.

tacck and others added 3 commits April 1, 2025 14:11
Fixes #296 

This change is to fix URLs that return 404 errors.

---
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license
…g does not find a specific count of resources (#251)

Fixes #257

As described in the issue, `CcApiContextProviderPlugin` should have the
way to ensure the result has exact one resource.

This PR adds the `expectedMatchCount` option to restrict the length of
results in `listResources()`.

Unit tests are added and modified ensure the changes.

---
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license

---------

Co-authored-by: Rico Huijbers <[email protected]>
api-extractor doc generation and upload
@iankhou iankhou closed this Apr 1, 2025
auto-merge was automatically disabled April 1, 2025 18:13

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2 pr/exempt-integ-test Skips the integ test steps if set.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants