Skip to content

fix(toolkit-lib): remove deprecated options #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrgrain merged 1 commit into from
Apr 3, 2025
Merged

fix(toolkit-lib): remove deprecated options #307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 0 additions & 23 deletions packages/@aws-cdk/toolkit-lib/lib/actions/deploy/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import type { BaseDeployOptions } from './private/deploy-options';
import type { Tag } from '../../api/aws-cdk';
import type { RequireApproval } from '../../api/shared-public';

export type DeploymentMethod = DirectDeploymentMethod | ChangeSetDeploymentMethod;

Expand Down Expand Up @@ -103,14 +102,6 @@ export interface DeployOptions extends BaseDeployOptions {
*/
readonly notificationArns?: string[];

/**
* Require a confirmation for security relevant changes before continuing with the deployment
*
* @default RequireApproval.NEVER
* @deprecated requireApproval is governed by the `IIoHost`. This property is no longer used.
*/
readonly requireApproval?: RequireApproval;

/**
* Tags to pass to CloudFormation for deployment
*/
Expand Down Expand Up @@ -146,20 +137,6 @@ export interface DeployOptions extends BaseDeployOptions {
*/
readonly assetBuildTime?: AssetBuildTime;

/**
* Change stack watcher output to CI mode.
*
* @deprecated has no functionality, please implement in your IoHost
*/
readonly ci?: boolean;

/**
* Display mode for stack deployment progress.
*
* @deprecated has no functionality, please implement in your IoHost
*/
readonly progress?: any;

/**
* Represents configuration property overrides for hotswap deployments.
* Currently only supported by ECS.
Expand Down
7 changes: 0 additions & 7 deletions packages/@aws-cdk/toolkit-lib/lib/actions/destroy/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,4 @@ export interface DestroyOptions {
* The arn of the IAM role to use
*/
readonly roleArn?: string;

/**
* Change stack watcher output to CI mode.
*
* @deprecated has no effect, please implement in IoHost instead
*/
readonly ci?: boolean;
}
2 changes: 0 additions & 2 deletions packages/@aws-cdk/toolkit-lib/lib/toolkit/toolkit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,7 +517,6 @@ export class Toolkit extends CloudAssemblySourceBuilder implements AsyncDisposab
await this._destroy(assembly, 'deploy', {
stacks: { patterns: [stack.hierarchicalId], strategy: StackSelectionStrategy.PATTERN_MUST_MATCH_SINGLE },
roleArn: options.roleArn,
ci: options.ci,
});

return;
Expand Down Expand Up @@ -1005,7 +1004,6 @@ export class Toolkit extends CloudAssemblySourceBuilder implements AsyncDisposab
const hotswap = options.hotswap ?? HotswapMode.HOTSWAP_ONLY;
const deployOptions: ExtendedDeployOptions = {
...options,
requireApproval: RequireApproval.NEVER,
cloudWatchLogMonitor,
hotswap,
extraUserAgent: `cdk-watch/hotswap-${hotswap === HotswapMode.FULL_DEPLOYMENT ? 'off' : 'on'}`,
Expand Down