fix(toolkit-lib): remove deprecated outdir option from watch #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: The `outdir` option in `WatchOptions` was deprecated and has been removed. Instead, the code now uses the assembly directory directly. The watch functionality has been updated to: 1. Remove the deprecated outdir parameter from WatchOptions 2. Use assembly.directory instead of the hardcoded 'cdk.out' default 3. Only exclude the outdir from watching if it's under the root directory 4. Update tests to reflect these changes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #313 +/- ##
==========================================
- Coverage 85.58% 85.39% -0.19%
==========================================
Files 223 223
Lines 37002 37002
Branches 4493 4461 -32
==========================================
- Hits 31668 31598 -70
- Misses 5233 5309 +76
+ Partials 101 95 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rix0rrr
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The watch functionality has been updated to:
BREAKING CHANGE: The
outdiroption inWatchOptionswas deprecated and has been removed. Instead, the code now determines the assembly directory directly. To explicitly restore the previous behavior, you add the value toWatchOptions.exclude.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license