feat(toolkit): add a return type for toolkit.destroy() #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`toolkit.deploy()` now returns information about the stacks it deployed.
Signed-off-by: github-actions <[email protected]>
`toolkit.deploy()` now returns information about the stacks it deployed.
`toolkit.destroy()` now returns information about the stacks it deployed.
rix0rrr
force-pushed
the
huijbers/destroy-return
branch
from
74303d3 to
d7a7cb6
Compare
Signed-off-by: github-actions <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #318 +/- ##
==========================================
+ Coverage 85.49% 85.61% +0.11%
==========================================
Files 219 219
Lines 24103 24250 +147
Branches 2585 2585
==========================================
+ Hits 20607 20761 +154
+ Misses 3445 3437 -8
- Partials 51 52 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rix0rrr
force-pushed
the
huijbers/destroy-return
branch
from
71eb7ff to
e54e964
Compare
Signed-off-by: github-actions <[email protected]>
otaviomacedo
approved these changes
Apr 4, 2025
`toolkit.rollback()` now returns information about the stacks it rolled back. Includes some refactoring that deduplicates return information between deploy/destroy and rollback. Closes aws/aws-cdk#33188 --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license --------- Signed-off-by: github-actions <[email protected]> Co-authored-by: github-actions <[email protected]>
iankhou
previously requested changes
Apr 6, 2025
Comment on lines
40
to
85
| export interface DeployedStack extends PhysicalStack { | ||
| /** | ||
| * Hierarchical identifier | ||
| * | ||
| * This uniquely identifies the stack inside the CDK app. | ||
| * | ||
| * In practice this will be the stack's construct path, but unfortunately the | ||
| * Cloud Assembly contract doesn't require or guarantee that. | ||
| */ | ||
| readonly hierarchicalId: string; | ||
|
|
||
| /** | ||
| * The outputs of the deployed CloudFormation stack | ||
| */ | ||
| readonly outputs: { [key: string]: string }; | ||
| } | ||
|
|
||
| /** | ||
| * An environment, which is an (account, region) pair | ||
| */ | ||
| export interface Environment { | ||
| /** | ||
| * The account number | ||
| */ | ||
| readonly account: string; | ||
|
|
||
| /** | ||
| * The region number | ||
| */ | ||
| readonly region: string; | ||
| } | ||
|
|
||
| /** | ||
| * Result interface for toolkit.deploy operation | ||
| */ | ||
| export interface DeployResult { | ||
| /** | ||
| * List of stacks deployed by this operation | ||
| */ | ||
| readonly stacks: DeployedStack[]; | ||
| } | ||
|
|
||
| /** | ||
| * Information about a deployed stack | ||
| */ | ||
| export interface DeployedStack extends PhysicalStack { |
Contributor
There was a problem hiding this comment.
Looks like some stuff got repeated here, maybe because of an automerge issue?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toolkit.destroy()now returns information about the stacks it deployed.Closes aws/aws-cdk#33190
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license